search

chromeos / cros-codecs

BSD 3-Clause "New" or "Revised" License
30 stars 11 forks source link

We shouldn't implement codec-specific methods for VaapiBackend #52

Closed dwlsalmeida closed 10 months ago

dwlsalmeida commented 1 year ago

We currently implement quite a few methods for VaapiBackend<(), M> in stateless/h264/vaapi.rs. This pollutes the namespace, as a structure used for all backends now contain methods that only work for a given codec without any extra generic parameters to hide them away or otherwise preclude them from being used elsewhere.

dwlsalmeida commented 11 months ago

I checked this and apparently all VA code is now using free functions. We should close.