chromeos / cros-codecs

BSD 3-Clause "New" or "Revised" License
30 stars 11 forks source link

av1: max for secondary strength looks incorrect #58

Closed Gnurou closed 11 months ago

Gnurou commented 11 months ago

As per Nicolas Dufresne:

the max for secondary strength is incorrect here, https://github.com/chromeos/croscodecs/blob/main/src/codec/av1/parser.rs#L921 Secondary strength is 2 bit in the bitstream as you apply the +1, its not even a range, is 0 1 2 4

Let's check and fix if needed.

dwlsalmeida commented 11 months ago

This is fine, the array is a bit larger than it should be, right @ndufresne ?

ndufresne commented 11 months ago

My bad, its fine indeed, you can close.