chromeos / virtio-media

BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Various fixes for ffmpeg and v4l2-proxy backends #12

Open aesteve-rh opened 1 week ago

aesteve-rh commented 1 week ago

A mix of different non-related fixes.

Fixes include:

If count == 0, then ioctl VIDIOC_CREATE_BUFS will set index to the current number of created buffers, and it will check the validity of memory and format.type.

So we do not want to clear buffers when we receive this.

If this PR feels a bit messy, as it includes different unrelated fixes, I will split them.

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Gnurou commented 2 days ago

Thanks, I think this looks mostly good! I hope my safety assumptions for the Sync implementations are correct, but I cannot say I am totally confident about it. The last patch is all the more welcome that I have never ever used createbufs, so it was likely buggy indeed. ><