chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
132 stars 30 forks source link

[Fishing] Missing error message 'Your fish got away.' #2410

Open ishidinho opened 2 years ago

ishidinho commented 2 years ago

What client do you play on?

enUS

Faction

Content Phase:

Current Behaviour

When a fish escapes during fissing, no interface error message appears.

Expected Blizzlike Behaviour

When a fish escapes during fishing because of too low fishing skill a interface error message 'Your fish got away.' should be displayed.

Source

No response

Steps to reproduce the problem

My test setup:

  1. Fishing skill 258
  2. Try to fish in Camp Mojache in Feralas
  3. No error message if a fish escapes

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/fc16abc30ea2e9412627ddd9d15868eac8aabb53

Operating system

Windows 10

Modules

Customizations

None

Server

ChromieCraft

ishidinho commented 2 years ago

Note: I disabled all addons, of course.

Shineslippers commented 2 years ago

Wowpedia Fishing Wowwiki Patch 3.1

You can now fish anywhere, regardless of skill. Every catch has the potential for fishing skill gains, but you are likely to catch worthless junk in areas that are too difficult for your skill.

Based on this there is can be 2 conditions:

  1. Not click on Fishing Bobber - you can't get skill up. Return message You fish got away.
  2. Click on Fishing Bobber - you can get skill up.

Probably this report is condition 2. I'm assuming it's about missing worthless junk that you can get if you fishing skill not high enough. Because with condition 1 everything is ok. According to Fishing skill requirements by zone Feralas Skill for 100% fish (no junk) catch rate is 300. WoWScrnShot_112721_191229

Azcobu commented 2 years ago

@ishidinho - when you say a fish escaped, do you mean that an empty loot screen appeared, or did you get a junk item?

If it was junk, that would be expected behaviour: "all casts will catch something and award a chance for a skill-up. However, if your skill level is too low for a zone, you will catch mostly vendor trash items. The skill level required to guarantee "no junk" catches is equivalent to the old "no get away" level." If, on the other hand, you got an empty loot screen, then that would be an issue.

Shineslippers commented 2 years ago

Yes, empty loot and skill up. I guess issue with junk. I never got any junk there. image

ishidinho commented 2 years ago

@Azcobu

Really nothing appears. No fish. No item. No empty loot screen. No error message.

Shineslippers commented 2 years ago

No empty loot screen could be caused by addons like xloot or auto-loot.

ishidinho commented 2 years ago

I preproduced the issue with all addons disabled before posting the issue.

Shineslippers commented 2 years ago

@Azcobu same as https://github.com/azerothcore/azerothcore-wotlk/issues/9208. Sometimes no loot. There is probably because day/night schedule. Can't reproduce no loot window only empty loot window WoWScrnShot_113021_125444

Azcobu commented 2 years ago

Merging this ticket into https://github.com/azerothcore/azerothcore-wotlk/issues/9208 and renaming that to reflect that it's a broader problem.

Azcobu commented 2 years ago

It just occurred to me that perhaps the disappearing window could be caused by auto-loot being on?

Shineslippers commented 2 years ago

Yea, i mentioned it 2 messages above https://github.com/chromiecraft/chromiecraft/issues/2410#issuecomment-981116941