chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
134 stars 30 forks source link

[Warrior] Sword Specilization #3221

Closed Cooties-cc closed 2 years ago

Cooties-cc commented 2 years ago

What client do you play on?

enGB

Faction

Content Phase:

Current Behaviour

Currently Sword Specialization (https://wotlkdb.com/?spell=12815) does not grant the extra white swing when it procs from a damaging spell. It only grants the extra swing on white attacks, or attacks that replace your next swing.

Expected Blizzlike Behaviour

Any damaging spell a warrior does should proc the ability, and grant an extra white swing.

Source

https://wowwiki-archive.fandom.com/wiki/Sword_Specialization_(warrior_talent)?oldid=2501528

Under the notes section : It is a common misconception that Sword Specialization can only proc off of normal (white) swings. This is not the case and is likely confusion over [Windfury Totem]. Windfury only procs off of normal (white) swings. Sword Specialization procs from all damaging attacks, including special attacks. The extra attack is normal melee swing (white attack) and is always done by the weapon in the main hand. It counts [Whirlwind] as a single attack for chance of proc.

Granted that this info seems to be more direct towards vanilla, but the mechanic wasn't changed over the patches (outside the CD added).

Steps to reproduce the problem

  1. Equip a sword or 2h sword on a warrior
  2. Enable Sword Specialization in the talents
  3. Use abilities on a target dummy
  4. When you get a proc, go to combat log and check damaging spell procs

Extra Notes

This issue seems to almost be identical to the issues Hand of Justice is experiencing. Bug report for that item (https://github.com/chromiecraft/chromiecraft/issues/2433) has been logged and known since early November of last year. Both of these would be greatly appreciated if they were fixed, more so the trinket, as it is a core trinket for basically every melee class to start of TBC.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/e8d3292533c7e5d18af15d9bffabd581bacbadf9

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

oysterdestroyer commented 2 years ago

I got curious and made a rogue on the PTR to test their "hack and slash" talent using a "/cast sinister strike /stopattack" macro and it looked like rogues are getting their extra attack off their yellow hits. I have no idea how wow server coding or whatever works but if my testing is correct maybe it could be useful in fixing Hand of Justice and Sword Specialisation since they're similar?

https://imgur.com/a/Alufz4h

For whatever reason I don't seem to get the 'gains 1 extra attacks through X' text on my yellow hits. I also never got the text (and no extra swing) when testing slam on my warrior with sword spec across an unlikely number of slams, obviously hard to confirm if it ever actually triggered though. Someone who has it display properly could maybe test the rogue as well.

fendwe commented 2 years ago

Could partly confirm this on the PTR.

Slam -> no proc WoWScrnShot_032322_231129

Rend -> no proc, only the following white swing procs the talent image

Cleave -> does proc image

Mortal Strike -> no proc, only the following white swing procs the talent image

Heroic Strike -> does proc image

I noticed somthing strange though (or i'm too unfamiliar with warriors to know better). When i had the warrior spamming Slam on a target for almost 2min without initiating autoattack, Sword Specialization would not proc at all. image

Looks to me, as if only those abilities proc the extra attack, that replace the normal (white) swing.