chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
134 stars 30 forks source link

Triggered Spells should not put you into combat #3905

Open Tereneckla opened 2 years ago

Tereneckla commented 2 years ago

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

Triggered spells, like Mage Ignite put both sides into combat when they trigger This leads to a very long combat timer when a mage has living bomb on a target and it crits

Expected Blizzlike Behaviour

Triggered Spells have no influence on the combat timer

Source

https://youtu.be/qavkjivhSkQ?t=696

Here you see the mage leaving combat with a crit of living bomb causing ignite to trigger 1 second ago

Proof that he has the living bomb glyph (ignite on the new target that had a previous casted living bomb on): https://youtu.be/qavkjivhSkQ?t=436

Steps to reproduce the problem

  1. Get 2 characters, 1 of them mage
  2. On the mage learn ignite and living bomb and .add 18970 2 and .add 45737
  3. Equip those rings
  4. Learn the Glyph
  5. Duel
  6. Cast Living Bomb
  7. Look at the combat status

Extra Notes

https://wowgaming.altervista.org/aowow/?spell=44457 https://wowgaming.altervista.org/aowow/?spell=12848

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/e6dd5d3e22d92dddc841079f9108275fd0359be1

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

Tereneckla commented 2 years ago

This most likely extends to other triggered spells, such as a druids Revitalize talent