search

chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
132 stars 30 forks source link

Diminishing returns mobs #4530

Open Toniculus opened 1 year ago

Toniculus commented 1 year ago

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

Mobs do not have diminishing returns on their CC For example : mobs in scarlet monastary library stuns for 5 seconds(Scarlet Gallant) ; if a player is stunned for 5 seconds and 2 seconds passed then another stun is applied to him ,he gets back to 5 seconds stun Same for the lizzard mobs in Maraudon "pristine waters" that silances for 6 seconds (Subterranean Diemetradon): if u r unlucky u can be silances forever

Expected Blizzlike Behaviour

certain spells and abilities become less effective against a target if used frequently within a short period of time.

Source

World of Warcraft: Wrath of the Lich King Patch 3.0.8 (2009-01-20): All Silence spells now have diminishing returns.

Stuns are affected by diminishing returns

Steps to reproduce the problem

Go in a dungeon and get CC by mobs , no diminishing returns

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/11530ecb95a35f66a2c220781172c57e0749ac48

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

Santaria94 commented 1 year ago

I found video from Wotlk and can't confirm the DR for silence in this particular case https://youtu.be/RLt2JDjFecA?t=64 - 1:05 The mention in the changelog probably refers to the PvP component

For stun effects, I think more research is needed.

Santaria94 commented 1 year ago

Can confirm the DR for the stun effect for Scarlet Monastery. Wrath Classic https://youtu.be/2hKau91Yw6U?t=159 - 2:40, 2:46

Jinteki01 commented 1 year ago

I made a Stun DR issue as well with multiple videos showing the DR in Blood Furnace and Scarlet Monastery.

https://github.com/chromiecraft/chromiecraft/issues/4599

Paradigmxd commented 1 year ago

Yes - Guys, honestly this will be a significantly serios Issue during Heroic TBC dungeons. BF and SHH in particular. We are all aware how annoying frustrating the pulls can be and if the tank is perma stunned no healing will save him from Rogues or Sentries that hit like trucks in heroics

Please - please address this DR issue!

Paradigmxd commented 1 year ago

https://wowwiki-archive.fandom.com/wiki/Diminishing_returns

Read the categories and regarding PVE section...check the historic patch changes to laugh a little bit but see that NPCs have a DR.... VS players...

Gultask commented 1 year ago

This issue has been proving hell to fix properly, but timer adjustments should relax it quite a fair bit. Let me know about any special cases but both Ramparts and BF should be much better after recent reworks (not applied yet to CC)

Paradigmxd commented 1 year ago

Hmm - maybe some help could be asked from other Private Servers? I know people dont like the toxicity and bad scripting overall in Warmane - but they have working DR as it should!

Also - purely educational @Gultask why is this such a hell to fix? It is interesting you say that because this is the first time I see this issue on a private server post 2015 (I draw my experience from Sunwell WOTLK realms, Lordaeron, Dalaran-wow). Is it because the core you guys use is super old/the rusty original stuff?

Paradigmxd commented 1 year ago

I am not coding expert but it is super interesting to understand nontheless!

Tereneckla commented 1 year ago

Afaik it is very easy to make a blanket "fix" The problem is that not every CC should have DR

krutoj87 commented 7 months ago

The "Tar Lurker" and "Tar Lord" mobs in "Un'Goro Crater", needed for the quest "Super Sticky", also can disarm a player back to back. I noticed the same behaviour on "Kenata Dabyrie" in "Arathi Highlands" while doing the quest "To Steal from Thieves". So the diminishing returns on disarm effects need to be checked to.

sogladev commented 2 months ago

Spells are categorized on their effects/mechanics with some manual assignments. Categories look incorrect to me[1]

Depending on who the spell is cast on, player or non-player, different categories can apply DR on the targetted player or non-player[2]. However we want different behavior depending on who casts the spell.

note: flags_extra has a CREATURE_FLAG_EXTRA_OBEYS_TAUNT_DIMINISHING_RETURNS for special NPCs that act like players like TOGC's PvP encounter

There's many more categories that DR when cast on players than cast on creatures. Creatures who cast on players is missing; This should only be a small subset of the categories that can affect player caster -> players

current implementation:

expected:

changes/implementation:

  1. update categories based on DR Data from WOTLK classic arena addon latest wotlk version of arena addon v2.27 https://github.com/XiconQoo/Gladdy-TBC/blob/3e34aca5916242d490e241779f8a60efa962c801/Libs/DRList-1.0/Spells.lua#L389 some mismatches to current:

    • scatter_shot, dragon's breath share DR
    • entrapment, frostbite, imp hamstring, imp wing clip share DR

  2. add handling non-boss creature caster DR should be relatively simple with dumb checks like this: https://github.com/azerothcore/azerothcore-wotlk/commit/b60a2ebffcfed4791be37fce039cb291f08b2788

I have listed categories that should DR for non-boss creature caster DR to player, solely based on read issues and my experience, but can't give a source

should not DR:

I've read some confusing/conflicting info in these issues/linked pr.