chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
132 stars 30 forks source link

Demonic Pact not working on some of the party members #5815

Open kikkomage opened 1 year ago

kikkomage commented 1 year ago

What client do you play on?

enUS

Faction

Horde

Content Phase:

70

Current Behaviour

https://wowgaming.altervista.org/aowow?spell=47240

So, there's an issue with Demonic Pact. It sometimes won't provide with the buff for party members. I tried to remove and re-summon.

There was no LoS in the pictures on the party members and you can see that it happened several times to several of the party members in this dungeon. The pictures here are just some examples. demonic_pact_3 demonic_pact_2 Demonic_pact_4 Demonic_Pact_5 Demonic_pact1

Expected Blizzlike Behaviour

https://www.wowhead.com/wotlk/spell=47236/demonic-pact#modifies

The spell tooltip says that it provides spell power to party/raid but in these pictures on some of the party members it wasn't working.

Source

https://www.wowhead.com/wotlk/spell=47236/demonic-pact#modifies

Steps to reproduce the problem

  1. Use demonic pact

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/a10c183e99a7c4880420886777e6b3e1c3308965

Operating system

Windows 11

Modules

Customizations

None

Server

ChromieCraft

AcetylGer commented 1 week ago

I have not noticed this bug yet but i have also not been tracking it. The only way to confirm this bug i can think of would be to write a weakaura that checks all party/raid members for the dp buff if you yourself have the buff. If i read aowow correctly then Demonic Pact has a range of 100 yards, only vision, and has the "Chance to miss" Flag. So party/raid members might be los'ing the buff or it missed. I dont know if it is supposed to be able to miss and i dont know if it takes the hit chance of the pet or the warlock. https://wowgaming.altervista.org/aowow/?spell=48090

On wowhead wotlk it does have different flags, it ignores LoS and is not missable, dont know which behaviour is 3.3.5 blizzlike: https://www.wowhead.com/wotlk/spell=48090/demonic-pact

AcetylGer commented 1 week ago

Also i think demonic pact should have a 20s icd as per patch 3.3.3. Aowow shows not icd. https://wowwiki-archive.fandom.com/wiki/Patch_3.3.3