chromiecraft / chromiecraft

ChromieCraft Discussions and Bug Tracker
https://www.chromiecraft.com
132 stars 30 forks source link

[Progression][SSC] The Cudgel of Kar'Desh mix-up #6388

Open balleny opened 9 months ago

balleny commented 9 months ago

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

the quest available to players: https://wowgaming.altervista.org/aowow/?quest=13431 also: this quest gives the title Champion of Naaru, which it must NOT

Expected Blizzlike Behaviour

Until removal of SSC and TK attunement, players should get quest https://wowgaming.altervista.org/aowow/?quest=10901. this quest should be linked as requirement to enter the dungeon and reward the title.

once the attunement requirement gets removed https://wowgaming.altervista.org/aowow/?quest=10901 gets replaced by https://wowgaming.altervista.org/aowow/?quest=13431 allowing players to complete the chain without granting the title (and also not granting access to the dungeon because the attunement requirement is dropped at that point).

Source

.

Steps to reproduce the problem

.

Extra Notes

The important part here is that a simple swap wouldnt be sufficient to correct the ill state.

1) remove the title being granted from the replacement quest to have wotlk correct state.

2) remove the replacement quest from the npc and replace it with the original quest to be correct for progression

3) every char ingame that has the replacement quest completed should get the original quest flagged as completed. then the replacement quest should get flagged as not completed.

4) lastly, make sure that the quests are mutually exclusive. if you completed one (the "history" one), you shouldnt see or be able to pick up the replacement one.

5) make sure SSC attunement is linked to the history quest.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/123bf37ee7e6763d9d7f4b778cfe8453577bce6c

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

elthehablo commented 9 months ago

Original progression module had the old quest. I changed it because wotlk uses the other one. One thing we could do is revert that quest in the prog module, and then make sure that the npc has this quest instead of the wotlk one. Up for debate though

balleny commented 9 months ago

its relevant in that sense that the old quest is linked to the achievement and the new one isnt. that is how it is supposed to be. completing the new one now, doesnt grant the achievement as supposed to (if not modified like with the title )

elthehablo commented 6 months ago

https://github.com/azerothcore/mod-progression-system/blob/main/src/Bracket_61_64/sql/world/progression_61_64_quest_template_attunement.sql the rewards are in-line with this file in mod-prog

balleny commented 6 months ago

exactly the issue: instead of swapping out the "new" quest and adding back in the "old" quest, adding the old quest as requirement to enter the raid, the new quest was modified.

the new quest (after attunement requirement dropped) MUST NOT count for the title and respective achievement. the old quest must do and should do so even in the disabled state.

but, here the old quest wasnt re-enabled, instead attributes (title, access) where artificially added to the new quest - which is not correct