search

chromium / axiom

Axiom Project
https://chromium.github.io/axiom/web_shell/
Apache License 2.0
53 stars 26 forks source link

Fixed closure annotations #130

Closed umop closed 9 years ago

umop commented 9 years ago

Fixes several closure-compiler complaints introduced in import dialog #115.

@ussuri This fixes all closure-compiler complaints. There is still one left for mv.

I had to remove the type annotation for copyPromises because I couldn't find an annotation which would work with Promise.all and it looked like that was what was done in other code.

ussuri commented 9 years ago

I've already taken care of mv in another PR. Will review this one now.

ussuri commented 9 years ago

LGTM.

I happen to have changed the same source somewhat in another PR in order to fix the JSHint errors and warnings (which were valid). Let's land this, and then I'll submit that for your review.

umop commented 9 years ago

Sounds goodl