search

chromium / axiom

Axiom Project
https://chromium.github.io/axiom/web_shell/
Apache License 2.0
53 stars 26 forks source link

I/O redirection part 3: redirect stdin + pipes #226

Closed ussuri closed 9 years ago

ussuri commented 9 years ago

@rpaquay

This is #201 redone and with pipes added, but sans sort (I'll commit new execs separately after this).

This PR largely implements what we discussed in person, but I had to alter some things to make it all work. I'll go over your comments to #201 once again tomorrow to see if I've missed anything.

ussuri commented 9 years ago

Ah, so the new execs have snuck in. Oh, well :)

ussuri commented 9 years ago

I should also write some tests: I'll do it later.

ussuri commented 9 years ago

@rpaquay PTAL

The stuff in ReadableFileStreamBuffer is not yet as I'd want it, but OpenContext.read() doesn't have a concept of chunk size to read, so the potential problems in ReadableFileStreamBuffer are currently masked. Regardless, while you're reviewing this, I'll work on fixing all this.

rpaquay commented 9 years ago

lgtm