search

chromium / axiom

Axiom Project
https://chromium.github.io/axiom/web_shell/
Apache License 2.0
53 stars 26 forks source link

Changed chrome extension to self-host. #241

Closed umop closed 9 years ago

umop commented 9 years ago

Sets up chrome extension to self host as filesystem (not yet providing executable command).

@rpaquay @ussuri

umop commented 9 years ago

Two additional notes:

@rpaquay I included the refactoring of WebSocketStreams in here, but I'll revert if you prefer. It will work independent of GenericStreams. I just wanted to reduce code dup.

@ussuri I copied the full chrome_api.js to externs with some additional missing references. It did look like the file had been intentionally paired down, though, so I can prune out unused externs if there is a reason to keep the file small (I figured there wasn't since it is not used during compilation, but just during checking). LMK, thanks!

umop commented 9 years ago

PTAL

umop commented 9 years ago

Cc @rginda

rpaquay commented 9 years ago

lgtm after last 2 comments addressed.