chromium / badssl.com

:lock: Memorable site for testing clients against bad SSL configs.
https://badssl.com
Apache License 2.0
2.81k stars 190 forks source link

Add `tls-v1-2` subdomain. Addresses #332. #345

Closed lgarron closed 6 years ago

lgarron commented 6 years ago

@christhompson, could you review?

This adds tls-v1-2 on port 1012, similar to how other protocol subdomains are implemented.

christhompson commented 6 years ago

Looks good to me. Do we also want to add it to the dashboard sets?

lgarron commented 6 years ago

Looks good to me. Do we also want to add it to the dashboard sets?

Good idea. Done.

(Note that not connecting to tls-v1-2 will show up as "OKAY" due to default behaviour, even though it is de facto required for being able to connect to any badssl.com resource with proper modern security practices. However, in general it is not required to be able to connect via TLS 1.2 in order to have the best security, since there are other alternatives like QUIC, SPDY, and HTTP/2.)