Closed rsolomakhin closed 5 years ago
I made an attempt at what I think is a better way of including log messages in this test case (and might be useful for other test cases where exposing logs visibly for mobile testing is useful), but couldn't push changes to this PR directly. Here's the diff based off of this PR: https://github.com/chromium/badssl.com/commit/793837ab337712dcf31bc814f3d69ce4ff5a1cb4
Roughly, this moves the log to be default-hidden and adds a toggle to the test case content area. It also styles the log to be a bit less obtrusive. WDYT?
Excellent! That's even better than what I wrote :-D
On Fri, Jun 21, 2019 at 1:57 PM Chris Thompson notifications@github.com wrote:
I made an attempt at what I think is a better way of including log messages in this test case (and might be useful for other test cases where exposing logs visibly for mobile testing is useful), but couldn't push changes to this PR directly. Here's the diff based off of this PR: 793837a https://github.com/chromium/badssl.com/commit/793837ab337712dcf31bc814f3d69ce4ff5a1cb4
Roughly, this moves the log to be default-hidden and adds a toggle to the test case content area. It also styles the log to be a bit less obtrusive. WDYT?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chromium/badssl.com/pull/392?email_source=notifications&email_token=AAH3EGK2RMYO7Y5HG6KEZ43P3UI7ZA5CNFSM4H2SGRDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJE6GA#issuecomment-504516376, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH3EGIVE3QTXHXIS3LXKF3P3UI7ZANCNFSM4H2SGRDA .
@christhompson : I've merged your proposed changes to this pull request. Git preserved your authorship, too!
For easier debugging on mobile devices, print the API return values and exception messages in the footer area of the page.