search

chromium / badssl.com

:lock: Memorable site for testing clients against bad SSL configs.
https://badssl.com
Apache License 2.0
2.78k stars 186 forks source link

Address issue #369 #454

Open Quuxplusone opened 3 years ago

Quuxplusone commented 3 years ago

Create a "client-nopass.pem" for use with Python requests, and add it to the download page.

Partly addresses #369. The reader will now be alerted to some kind of difference between client.pem and client-nopass.pem, and will be more alert to the "Passphrase" column. (I've also changed the wording from "Password" to "Passphrase" as the latter is what openssl calls it, so it's what people would be Ctrl+F'ing for.)

Using a passphrase other than "badssl.com" (e.g. "hunter2", "correct horse battery staple", "god") for the other files would also be great, but is a larger change, I think.

googlebot commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Quuxplusone commented 3 years ago

Ping! (@april perhaps? as apparently you were relevant to #369 as recently as two years ago :))

Quuxplusone commented 2 years ago

Ping! @christhompson perhaps?