chromium / badssl.com

:lock: Memorable site for testing clients against bad SSL configs.
https://badssl.com
Apache License 2.0
2.78k stars 186 forks source link

Add `tls-v1-3` subdomain. #464

Open c0r0n3r opened 3 years ago

c0r0n3r commented 3 years ago

This adds tls-v1-3 on port 1013, similar to how other protocol subdomains are implemented. Also adds the test to the dashboard.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

lgarron commented 3 years ago

If I recall correctly, we were using a version of nginx that doesn't support TLS 1.3. Have you been able to test this change using Docker?

hellow554 commented 2 years ago

If I recall correctly, we were using a version of nginx that doesn't support TLS 1.3.

That's unfortunately correct. Version 1.10.3 is used, 1.13 is needed atleast.

Is there a reason not to update to the latest stable version 1.20? It's not available in the default repo, but in the nginx repo. Maybe worth an update?

Maybe worth an update of the whole ubuntu from 16.04 to 20.04?

onefreddy commented 2 years ago

I join the topic, I think you need to quickly refresh your nginx. I would like to see a working subdomain in the mode tls 1.3 only