search

chromium / caterpillar

Project to investigate porting Chrome Apps to websites.
Apache License 2.0
59 stars 31 forks source link

`chrome.runtime` should be available to caterpillar.js #8

Closed m-alger closed 8 years ago

m-alger commented 8 years ago

Currently, the runtime polyfill is only counted as a requirement if there's an explicit call to it. However, errors are stored in chrome.runtime.lastError. The runtime polyfill should always be a requirement and should be loaded before any other polyfills.

m-alger commented 8 years ago

Implemented in this CL.

m-alger commented 8 years ago

Instead of being a requirement, chrome.runtime should be stubbed in caterpillar.js, so that chrome.caterpillar.setError will work fine but none of the other runtime functionality will be available. This should be done such that the actual runtime polyfill can be loaded later without conflicts.

m-alger commented 8 years ago

Resolved in this CL.