chromium / hstspreload.org

:lock: Chromium's HSTS preload list submission website.
https://hstspreload.org
BSD 3-Clause "New" or "Revised" License
781 stars 92 forks source link

JavaScript errors #94

Closed bardiharborow closed 7 years ago

bardiharborow commented 7 years ago

I'm now getting console errors when checking the status of a domain:

From URL parameter: google.com
view.js:92 Uncaught TypeError: Cannot set property 'textContent' of null
    at PreloadView._clearIssues (view.js:92)
    at PreloadView.clearDomainSpecificElements (view.js:53)
    at PreloadForm.checkDomain (form.js:25)
    at PreloadForm (form.js:18)
    at form.js:209
_clearIssues @ view.js:92
clearDomainSpecificElements @ view.js:53
checkDomain @ form.js:25
PreloadForm @ form.js:18
(anonymous) @ form.js:209
?domain=google.com:17 Uncaught ReferenceError: Form is not defined
    at ?domain=google.com:17
lgarron commented 7 years ago

Hmm, I have occasionally seen issues like this during development, probably due to caching. Does it work in a fresh browser profile? On Fri, Aug 4, 2017 at 22:26 Bardi Harborow notifications@github.com wrote:

I'm now getting console errors when checking the status of a domain:

From URL parameter: google.com view.js:92 Uncaught TypeError: Cannot set property 'textContent' of null at PreloadView._clearIssues (view.js:92) at PreloadView.clearDomainSpecificElements (view.js:53) at PreloadForm.checkDomain (form.js:25) at PreloadForm (form.js:18) at form.js:209 _clearIssues @ view.js:92 clearDomainSpecificElements @ view.js:53 checkDomain @ form.js:25 PreloadForm @ form.js:18 (anonymous) @ form.js:209 ?domain=google.com:17 Uncaught ReferenceError: Form is not defined at ?domain=google.com:17

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chromium/hstspreload.org/issues/94, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPJDuZeO00aOke_tfrq3oIpWUl39lbNks5sU_0fgaJpZM4OuXsS .

lgarron commented 7 years ago

Yep, the Form object was introduced in 7e95ca16218c51e2dc766d5e18fa8815f5623f5b, so you have an outdated form.js.

bardiharborow commented 7 years ago

Yep. A hard reload fixed everything. I'm not sure if there's a way to prevent this happening in the future.