search

chromium / permission.site

A site to test the interaction of web APIs and browser permissions.
https://permission.site/
BSD 3-Clause "New" or "Revised" License
1.18k stars 116 forks source link

Make one-time.html more generic. #116

Closed panmari closed 4 months ago

panmari commented 4 months ago

The page is also useful for testing other features, e.g. behavior of the permission API across browsers.

panmari commented 4 months ago

If one-time.html is going to move, I think it should have a redirect. Since we're using GitHub Pages, that will need a <meta> redirect.

If we're moving it, I would also slightly prefer /permision-status/ (i.e. using a file at /permision-status/index.html) rather than /permission-status.html, but that's more a matter of opinion.

Makes sense, done.

panmari commented 4 months ago

@lgarron did I address your concerns?

engedy commented 4 months ago

I'm going to go ahead and merge this in the interest of expediency, Lucas, let us know if you have any additional concerns.

engedy commented 3 months ago

@panmari Could you please send us a PR to address those nits?

panmari commented 3 months ago

I addressed the nits in #118

engedy commented 3 months ago

Thank you, approved that.