search

chromium / permission.site

A site to test the interaction of web APIs and browser permissions.
https://permission.site/
BSD 3-Clause "New" or "Revised" License
1.18k stars 116 forks source link

Added 'Device Orientation' and download code file #80

Closed zaidajani closed 3 years ago

zaidajani commented 3 years ago

Device orientation Is an important thing, Which is added Download code file shows at scan "this can harm your system or couldn't verify"

Added two more buttons for testing these.

lgarron commented 3 years ago

Thanks for helping out!

Unfortunately, though, I don't think we can land this as-is. Some feedback:

  1. These are two fairly different concepts; could you make them into separate PRs?
  2. It seems your PR reformats a lot of the code. Could you make sure to keep the existing style as much as possible, and keep the changed lines minimal and relevant? (If you want to propose a standard way to format the code, that should be in a separate PR and ideally easy for others to comply with, e.g. using a standard formatting or CI check)
  3. You have at least one very prominent user-visible typo; could you do a pass to stay consistent with the existing capitalization as well?
  4. Could you provide some context about the device orientation API here?
    • Spec
    • Documentation (MDN)
    • Availability (e.g. caniuse.com)
    • Any flags you need in current browsers (which should also be described at the bottom of the page).
  5. I don't think it's good idea to try to host content that is meant to be detected as dangerous — this could interfere with other uses of the site. https://testsafebrowsing.appspot.com/ is the appropriate place for this.
zaidajani commented 3 years ago

Thanks for checking out my pull request, I will try to make everything accordingly and will submit a new one soon.

As this was one of my first pull requests, I was not able to make it as per your instructions, But next time, I will try to follow the format in your feedback

Thanks