search

chromium / subspace

A concept-centered standard library for C++20, enabling safer and more reliable products and a more modern feel for C++ code.; Also home of Subdoc the code-documentation generator.
https://suslib.cc
Apache License 2.0
89 stars 15 forks source link

Replace deprecated endswith() with ends_with(). #436

Closed veluca93 closed 10 months ago

veluca93 commented 10 months ago

Can we avoid the reformatting changes? My clang-format is going to put them back on the next save. Maybe it would be nice to have a fixed clang-format version, it’s kind of a mess with how changes all the time. Anyway if it’s a pain it’s okay…

Just needed a commit -p :-)

danakj commented 10 months ago

Can we avoid the reformatting changes? My clang-format is going to put them back on the next save. Maybe it would be nice to have a fixed clang-format version, it’s kind of a mess with how changes all the time. Anyway if it’s a pain it’s okay…

Just needed a commit -p :-)

TIL about that flag :) Thanks!

danakj commented 10 months ago

Oh wow okay looks like clang 18 broke in a fun way:

Error while processing /home/runner/work/subspace/subspace/sus/num/i8_unittest.cc.
error: no such file or directory: '@sus/CMakeFiles/subspace_unittests.dir/mem/addressof_unittest.cc.o.modmap'
[2/99] /home/runner/work/subspace/subspace/sus/mem/addressof_unittest.cc

I will move it to 17 for now.

danakj commented 10 months ago

I will merge this, looks like it's not a clang-18 thing, maybe cmake.. but this CL is fine.