search

chromium / suspicious-site-reporter

Extension for reporting suspicious sites to Safe Browsing.
Apache License 2.0
96 stars 22 forks source link

Suspicious site reporter overrides "hide url schemes" flag in Chrome #26

Closed ghost closed 5 years ago

ghost commented 5 years ago

This happens on latest version of Stable and Canary Google Chrome

When the extension is enabled, my flags no longer work

Captura de Pantalla 2019-07-27 a la(s) 08 32 02

Captura de Pantalla 2019-07-27 a la(s) 08 32 25

Captura de Pantalla 2019-07-27 a la(s) 08 32 15

But when I disable the extension, the flags are working as intended again

Captura de Pantalla 2019-07-27 a la(s) 08 32 33

Captura de Pantalla 2019-07-27 a la(s) 08 33 15

I made sure that the Google`s Suspicious site reporter is the responsible for this behavior

livvielin commented 5 years ago

Hi! Thanks for filing. This works as intended--we want to give users the most information possible to make a decision on whether the site is suspicious, including showing the full URL. We do this by preventing URL elisions in Chrome when the extension is enabled. I'll close out this bug for now, but feel free to reopen if you have any questions or concerns about this feature.

ericlaw1979 commented 5 years ago

Interestingly, this is hardcoded inside Chrome itself. https://cs.chromium.org/chromium/src/chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.cc?l=80&rcl=390b11af93e5be31dda6e46a056d5eed60277f09

ericlaw1979 commented 5 years ago

The presence of this extension also seems to override chrome://flags/#enable-query-in-omnibox