Open ericlaw1979 opened 5 years ago
Currently in older versions of Chrome that don't have the API, or from custom builds with a different extension ID, there is a special bubble (https://github.com/chromium/suspicious-site-reporter/blob/master/extension/popup.js#L202), whereas empty referrer chains should have a bubble that says 'No referrer found' (https://github.com/chromium/suspicious-site-reporter/blob/master/extension/popup.js#L198). I wonder if the bug here specific to non-Chrome browsers is that the (chrome.safeBrowsingPrivate && chrome.safeBrowsingPrivate.getReferrerChain) check errors out and the whole function call fails?
I've noticed that when running in non-Chrome browsers, the![image](https://user-images.githubusercontent.com/4192774/62295638-20e94100-b433-11e9-81a9-01fc5e968af1.png)
Referrer Chain
appears to always be empty and the preview that appears when clicked is confusing (it looks like a tooltip, but it's meant to show a list).It seems like the preview should explicitly say something (like "None") when the referrer list is blank, and in browsers where the private API isn't available perhaps this entire area of the popup should be removed?