Regression: No longer works in MS Edge (Chrome OK)

chromium / suspicious-site-reporter

Extension for reporting suspicious sites to Safe Browsing.

Apache License 2.0

95 stars 22 forks source link

Regression: No longer works in MS Edge (Chrome OK) #50

Closed ericlaw1979 closed 5 years ago

ericlaw1979 commented 5 years ago

v1.1.9 seems to fail in Microsoft Edge. Possibly due to refactoring and unavailability of the SafeBrowsing private API?

ericlaw1979 commented 5 years ago

https://github.com/chromium/suspicious-site-reporter/pull/44/files#diff-b927923d29083160dabd5cfeeda3c3d0R183 seems like a likely culprit.

ericlaw1979 commented 5 years ago

Notably, the extension does not have this problem if you download the source from GitHub and compile it locally; the local version shows

|'safeBrowsingPrivate' is not allowed for specified extension ID.|

while the official version does not. So it seems likely to be inside an safeBrowsingPrivate block.

ericlaw1979 commented 5 years ago

In Chrome's safeBrowsingPrivate API, we have this

if (!SafeBrowsingNavigationObserverManager::IsEnabledAndReady(profile))
    return RespondNow(NoArguments());

whereas the webStorePrivate version of getReferrerChain does this:

if (!SafeBrowsingNavigationObserverManager::IsEnabledAndReady(profile))
    return RespondNow(ArgumentList(
        api::webstore_private::GetReferrerChain::Results::Create("")));

livvielin commented 5 years ago

v1.20 with your patch is now in the webstore--let me know if there are still issues Edge! Thanks!

ericlaw1979 commented 5 years ago

v1.2 looks good in Edge. Thanks!