chromium / vs-chromium

A Visual Studio extension containing a collection of tools to help contributing code to the Chromium project.
BSD 3-Clause "New" or "Revised" License
311 stars 90 forks source link

Revise default include/exclude patterns for Chromium enlistements #70

Open rpaquay opened 4 years ago

rpaquay commented 4 years ago

The list of default files to include/exclude for Chromium enlistments was written years ago and has not been updated since then. For example, the search pattern exclude "*.s" files (assembly source files). There is not reason to do that anymore.

The default files are located here:

https://github.com/chromium/vs-chromium/tree/master/src/Server/Configuration

They can be overridden using custom configuration files, but the list should be simplified for more general usage.

rpaquay commented 4 years ago

@randomascii fyi

randomascii commented 4 years ago

It could also be helpful to have an action that takes the defaults and creates a vs-chromium-project.txt file for editing. Right now switching from the defaults to a configuration file is a big change with unclear consequences.

rpaquay commented 4 years ago

Note: This was implemented in https://github.com/chromium/vs-chromium/commit/c062ad5ec8e2ffd4acc93cef2fcfdcdb5eadee50

Before;

After;

That is quite an increase in memory usage (~50%). Most of the increase come from files with these extensions:

rpaquay commented 4 years ago

Fixed in v0.9.37