search

chromium / vs-chromium

A Visual Studio extension containing a collection of tools to help contributing code to the Chromium project.
BSD 3-Clause "New" or "Revised" License
311 stars 90 forks source link

Fix the Attach Dialog to show command lines and Add Memory Column [pr] #74

Closed sushanthr closed 1 year ago

sushanthr commented 4 years ago

ProcessViewItem initializes itself lazily, unless the Category accessor is called the command line field is not populated. This changes fixes the issue by reading the command line after the Category is read.

Additionally this change adds the Private memory usage as a field. This field can be used to pick the right renderer process, since spare renderers tend to have lower private memory usage.

sushanthr commented 4 years ago

@rpaquay would it be possible for you to review this change ? Surprisingly the UI to add reviewers is not present for me.