search

chromium / vs-chromium

A Visual Studio extension containing a collection of tools to help contributing code to the Chromium project.
BSD 3-Clause "New" or "Revised" License
311 stars 90 forks source link

single server multiple clients #76

Open rkhoury opened 3 years ago

rkhoury commented 3 years ago

Hello, and many thanks for an awesome extension.

I have the use-case of a very large codebase with many solutions all with overlapping project/file dependencies - so all inherit the same vs-chromium-project.txt. I've noticed when I have more than one VS instance open that all of the instances appear to maintain their own server, and when a few files change the many millions of files in this codebase get reviewed with each VS instance and the computer load is too significant to ignore.

So I'm wondering if it's possible to launch this with a single server that all VS instances could connect to, or how hard that might be to implement? It would make my use-case much nicer to deal with rather than having several multi-gigabyte databases all getting updated redundantly.

Many thanks again.

rkhoury commented 3 years ago

Perhaps this is somewhat related to #50, though I'd still like the ability to search from VS.

rpaquay commented 3 years ago

This is a good idea. It would require some changes to the underlying protocol to include some sort of "client id" to each request, because right now the underlying protocol assumes one client per server instance. It would also require changing the server process tracking code inside the VS plugin to ensure the server "daemon" is not killed when VS exits. Other that that, most of the server code could remain as is to support this use case.

rkhoury commented 3 years ago

Thanks for the reply, @rpaquay . If I feel brave, and when I get the time, I'll try this out.