chromium / web-page-replay

DEPRECATED - Use WebPageReplayGo instead:
https://github.com/catapult-project/catapult/blob/master/web_page_replay_go/README.md
Apache License 2.0
235 stars 75 forks source link

Bug with script injection due to minification #69

Closed nickie closed 8 years ago

nickie commented 8 years ago

If you try injecting the following script:

var url = "http://google.de/";

MinifyScript will treat "//" as a comment and the injected script will not work. Minification only happens when reading the injected scripts from files, so the tests will not catch this. I'm uploading a CL to fix this.

nedn commented 8 years ago

Fixed by @nickie