search

chromiumembedded / cef

Chromium Embedded Framework (CEF). A simple framework for embedding Chromium-based browsers in other applications.
https://bitbucket.org/chromiumembedded/cef/
Other
3.31k stars 463 forks source link

cefclient 3282 fails to build on mac #2347

Closed magreenblatt closed 6 years ago

magreenblatt commented 6 years ago

Original report by Dan Kegel (Bitbucket: DanKegel, GitHub: DanKegel).

It seems https://bitbucket.org/chromiumembedded/cef/src/552a3bf353bd02a3592962c109291d37ca1059d9/tests/ceftests/display_unittest.cc removed the newline from the end of display_unittest.cc, causing clang to opine:

/Users/dank/src/oblong-cef/btmp/cef_binary_3.3282.1724.gc61e4a2_macosx64/tests/ceftests/display_unittest.cc:456:2: error: no newline at end of file [-Werror,-Wnewline-eof]
}
 ^
1 error generated.

when building cefclient etc. from the prebuilt tarball (in this case, one I made, but I just run the normal automated build).

magreenblatt commented 6 years ago

Original comment by Dan Kegel (Bitbucket: DanKegel, GitHub: DanKegel).

See https://bitbucket.org/chromiumembedded/cef/pull-requests/142/avoid-superficial-compiler-errors-when/diff

magreenblatt commented 6 years ago

Thanks, fixed in master revision 6e457d6 (bb) and 3282 branch revision 8d826cb (bb).

magreenblatt commented 6 years ago