Closed magreenblatt closed 5 months ago
Use Chrome file dialogs on all platforms and runtimes (fixes issue #3314)
All file dialogs irrespective of source, platform and runtime will now be routed through CefFileDialogManager and trigger CefDialogHandler callbacks (see issue #3293).
Adds Chrome runtime support for CefBrowserHost::RunFileDialog and CefDialogHandler callbacks.
Adds Alloy runtime support for internal GTK file and print dialogs on Linux subject to the following limitations:
Due to the above limitations no dialog implementation is currently provided for
Views + multi-threaded-message-loop on Linux. In cases where both
implementations are supported the cefclient version is now behind an optional
--use-client-dialogs
command-line flag.
Expressly forbids multiple simultaneous file dialogs with the internal platform implementation which uses modal dialogs. CefDialogHandler will still be notified and can optionally handle each request without a modal dialog (see issue #3154).
Removes some RunFileDialog parameters that are not supported by the Chrome file dialog implementation (selected_accept_filter parameter, cef_file_dialog_mode_t overwrite/read-only flags).
→ <<cset 2ea7459a89fb (bb)>>
This will be completed in issue #3681 (OSR = Chrome bootstrap + Alloy style).
Original report by me.
This issue involves the following functionality currently supported by the Alloy runtime:
CefWindowInfo.SetAsWindowless
andCefRenderHandler
Most likely to be supported for the Chrome runtime via the Ozone layer (see issue #3263).
The following capabilities would need to be implemented in combination with OSR support:
DialogTest.*
,JSDialogTest.*
,LifeSpanTest.*
; currently uses default Chrome dialogs).See issue
#2969for background on the Chrome runtime.