chromiumembedded / cef

Chromium Embedded Framework (CEF). A simple framework for embedding Chromium-based browsers in other applications.
https://bitbucket.org/chromiumembedded/cef/
Other
3.13k stars 450 forks source link

cefclient: Windows: Japanese IME popup is placed incorrectly with OSR #3313

Open magreenblatt opened 2 years ago

magreenblatt commented 2 years ago

Original report by Andrew Smith (Bitbucket: Andrew Smith).


The Japanese IME popup is displayed on the bottom right side of the screen when the composition starts.

This only happens when using the offscreen rendering.

Steps:

cefclient.exe --multi-threaded-message-loop --no-sandbox --off-screen-rendering-enabled --enable-gpu

The results are as shown in the image above. It seems like the issue is that the browser is not provided the character bounds until after the composition has started and so the calls to position the ime candidate window are not made until after the window has been shown. I just tested with the latest cef client - 100.0.22+g4a1240d+chromium-100.0.4896.88 / Chromium 100.0.4896.88.

Note: This issue does not happen when not using offscreen rendering (e.g. cefclient.exe --multi-threaded-message-loop --no-sandbox) presumably because the bounds are known earlier.

magreenblatt commented 2 years ago

Issue #3321 was marked as a duplicate of this issue.

magreenblatt commented 2 years ago

This is something that needs to be fixed in the client, possibly with the assistance of new/modified CEF API.

magreenblatt commented 2 years ago

See also issue #3306

magreenblatt commented 2 years ago

Issue #2348 was marked as a duplicate of this issue.

magreenblatt commented 1 year ago

windows: cefclient: Fix crash when triggering IME popup (see issue #3313)

→ <<cset 9f7a59536c21 (bb)>>

magreenblatt commented 1 year ago

Testing with OSR at current master (M105), I am able to reproduce this issue when typing ‘a' in the search field with Japanese + Hiragana on first launch of cefclient only. It also reproduces with Chinese input on first launch (instructions from issue #3306). It does not reproduce (popup is correctly placed) on the 2nd+ time typing in the search field.

magreenblatt commented 1 year ago

Screenshot of incorrect placement attached.

magreenblatt commented 1 year ago

Original comment by Andrew Smith (Bitbucket: Andrew Smith).


If you’re changing the title to the specific issue I was reporting then perhaps you might reopen 3321 since that is no longer related to what you might fix when you get to this one?

magreenblatt commented 1 year ago

windows: cefclient: Fix crash when triggering IME popup (see issue #3313)

→ <<cset 5074b14714c4 (bb)>>

magreenblatt commented 1 year ago

windows: cefclient: Fix crash when triggering IME popup (see issue #3313)

→ <<cset 75c6895fb532 (bb)>>

magreenblatt commented 1 year ago

If you’re changing the title to the specific issue I was reporting then perhaps you might reopen 3321 since that is no longer related to what you might fix when you get to this one?

Agreed and done.

magreenblatt commented 2 years ago
magreenblatt commented 1 year ago
magreenblatt commented 1 year ago