chromiumembedded / cef

Chromium Embedded Framework (CEF). A simple framework for embedding Chromium-based browsers in other applications.
https://bitbucket.org/chromiumembedded/cef/
Other
3.38k stars 467 forks source link

Typo in CMakeLists.txt #3775

Closed MatthewFagan closed 1 month ago

MatthewFagan commented 2 months ago

Describe the bug There appears to be a typo on line 146 of CMakeLists.txt

The line is: set_property(GLOBAL PROPERTY OS_FOLDERS ON)

However, OS_FOLDERS is not a cmake property. However, there is a CMake property USE_FOLDERS So, I think this line is a typo for set_property(GLOBAL PROPERTY USE_FOLDERS ON)

CMake prior to 3.26 defaulted USE_FOLDERS to OFF, but since 3.26 defaults it to ON. So changing the line should not have any impact.

But the typo makes it difficult for newbies to the project since we end up googling for a property that doesn't exist. (Google results are purely for CEF and its downstreams)