CEF branch 6613 not building

shagkur commented 2 months ago

Describe the bug depot_tools rasies an exception during the automate.py execution. Seems changes made to depot_tools on friday the 6th september led to this exception (before that branch was setting up fine).

To Reproduce

Start building from branch by executing automate.py (as describe the MasterBuild wiki)

Expected behavior setup finishes and build can start.

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

OS: Linux ubuntu 20.04LTS
CEF Version: 128.0.6613.120

Note: Seems this branch also need to pin to a specific commit of depot_tools now.

Mellnik commented 2 months ago

I just compiled the 6613 branch with the latest depot tools without errors.

shagkur commented 2 months ago

Okay. Interesting. As well on ubuntu 20.04? And from scratch? But looking at the changelog of the depot_tools, the (imo) offending change from friday got reverted yesterday. I guess that probably fixed it (again) now. Will try again.

shagkur commented 2 months ago

It still fails for me:

src/docs/website (ERROR)
----------------------------------------
[0:00:01] Started.
----------------------------------------
Traceback (most recent call last):
  File "/build/cef/depot_tools/metrics.py", line 302, in print_notice_and_exit
    yield
  File "/build/cef/depot_tools/gclient.py", line 4638, in <module>
    sys.exit(main(sys.argv[1:]))
             ^^^^^^^^^^^^^^^^^^
  File "/build/cef/depot_tools/gclient.py", line 4624, in main
    return dispatcher.execute(OptionParser(), argv)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/cef/depot_tools/subcommand.py", line 254, in execute
    return command(parser, args[1:])
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/cef/depot_tools/gclient.py", line 3977, in CMDsync
    ret = client.RunOnDeps('update', args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/cef/depot_tools/gclient.py", line 2436, in RunOnDeps
    work_queue.flush(revision_overrides,
  File "/build/cef/depot_tools/gclient_utils.py", line 1026, in flush
    reraise(e[0], e[1], e[2])
  File "/build/cef/depot_tools/gclient_utils.py", line 53, in reraise
    raise value
  File "/build/cef/depot_tools/gclient_utils.py", line 1105, in run
    self.item.run(*self.args, **self.kwargs)
  File "/build/cef/depot_tools/gclient.py", line 1251, in run
    self._got_revision = self._used_scm.RunCommand(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/cef/depot_tools/gclient_scm.py", line 137, in RunCommand
    return getattr(self, command)(options, args, file_list)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/cef/depot_tools/gclient_scm.py", line 664, in wrapper
    return_val = f(*args)
                 ^^^^^^^^
  File "/build/cef/depot_tools/gclient_scm.py", line 866, in update
    strp_current_url = current_url[:-4] if current_url.endswith(
                                           ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'endswith'

Traceback (most recent call last):
  File "/build/cef/automate/automate-git.py", line 1265, in <module>
    run("gclient sync %s--nohooks --with_branch_heads --jobs 16" % \
  File "/build/cef/automate/automate-git.py", line 66, in run
    return subprocess.check_call(
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['gclient', 'sync', '--nohooks', '--with_branch_heads', '--jobs', '16']' returned non-zero exit status 1.

shagkur commented 2 months ago

Works with ubuntu 22.04 tho

Mellnik commented 2 months ago

I am sorry, I misread that. It works on Windows for me, not on Linux.

magreenblatt commented 2 months ago

The automated builders are also fine. As this is an issue with depot_tools you can file a bug at https://crbug.com.

chromiumembedded / cef

CEF branch 6613 not building #3788