magreenblatt
commented
2 weeks ago The BrowserView should receive focus when the cefsimple app is launched due to the RequestFocus call. For example, when loading google.com you should see a blinking cursor on the search field.
When I click outside the app, OnTakeFocus never fires up
This may only be called when focus moves to a different element in the same window, not when the window itself loses focus.
CefWindow's RemoveAllAccelerators does nothing
This may not remove accelerators registered internally by Chrome.
Describe the bug I am trying to modify cefsimple example and set focus on the browser when the app is first launched. I found out that it does not work, unless I explicitly click somewhere in the browser.
To Reproduce Steps to reproduce the behavior:
Implement OnPreKeyEvent. In my case, I was trying to prevent accelerators keys. Example (you can add a cout here, and you will see it is never triggered at app first launch, meaning that the browser did not receive focus):
bool SimpleHandler::OnPreKeyEvent(CefRefPtr browser,
const CefKeyEvent& event,
CefEventHandle os_event,
bool* is_keyboard_shortcut) {
if (event.type != KEYEVENT_RAWKEYDOWN &&
event.type != KEYEVENT_KEYDOWN)
return false;
// Check for modifiers bool ctrl = (event.modifiers & EVENTFLAG_CONTROL_DOWN) != 0; bool shift = (event.modifiers & EVENTFLAG_SHIFT_DOWN) != 0; bool cmd = (event.modifiers & EVENTFLAG_COMMAND_DOWN) != 0; // For macOS //bool alt = (event.modifiers & EVENTFLAG_ALT_DOWN) != 0;
// Helper lambda to check for ctrl on Windows/Linux or cmd on macOS auto ctrlOrCmd = [ctrl, cmd]() {
if defined(OS_MAC)
else
endif
};
// Block F1, F7, F12 (DevTools) if (event.native_key_code == 0xffc9 || // Linux F12 event.windows_key_code == VK_F12 || // Windows F12 event.native_key_code == 0x7B || // macOS F12 event.native_key_code == 0xffbe || // Linux F1 event.windows_key_code == VK_F1 || // Windows F1 event.native_key_code == 0x7A || // macOS F1 event.native_key_code == 0xffc4 || // Linux F7 event.windows_key_code == VK_F7 || // Windows F7 event.native_key_code == 0x76) { // macOS F7 return true; }
// Block any combination where Ctrl or Cmd is pressed if (ctrlOrCmd()) { return true; }
return false; }
Set focus wherever appropriate, to window, browser_view, and browser.
Example: in SimpleWindowDelegate, browserview->RequestFocus(); Implement OnBeforeResourceLoad with browser->GetHost()->SetFocus(true); Implement OnLoadEnd with browser->GetHost()->SetFocus(true); Implement delayed focus to the browser in OnWindowCreated; Implement CefFocusHandler and OnFocusedNodeChanged (it won't get fired at app first launch).
Expected behavior Cefbrowser should receive focus at app startup.
Versions (please complete the following information):
Additional context I only tested cefsimple with the url "https://www.google.com".
I cannot reproduce on Google Chrome, because it's not possible to determine which component is having focus at first launch.
I also noticed that, once the browser receives focus, OnFocusedNodeChanged correctly triggers when I click inside the browser. But When I click outside the app, OnTakeFocus never fires up. Also, CefWindow's RemoveAllAccelerators does nothing, always in respect to app's startup. So it must be some general issue with focus.