search

chromiumembedded / cef

Chromium Embedded Framework (CEF). A simple framework for embedding Chromium-based browsers in other applications.
https://bitbucket.org/chromiumembedded/cef/
Other
3.4k stars 468 forks source link

[CEF3] Crashing inside prerenderer client #608

Closed magreenblatt closed 12 years ago

magreenblatt commented 12 years ago

Original report by Dmitry Azaraev (Bitbucket: Mystic Artifact).

Original issue 608 created by fddima on 2012-05-28T11:00:29.000Z:

Reproduce problem, using CEF3/651:

  1. Open CEF3's cefclient.
  2. Enter URL: http://www.google.com.ua/\#hl=uk&q=html5test (it will be redirected in more coplex (http://www.google.com.ua/\#hl=uk&q=html5test&fp=1&bav=on.2,or.r\_gc.r\_pw.r\_qf.,cf.osb&cad=b).
  3. Wait 2-10 secs - and you will got crash (in both debug and release versions).

Of course this pages opened normally in Chrome (21.0.1145.0 dev-m).

Sorry, can't obtain textual callstack (it is not writes in any file?), so see attached screenshot. Selected line with assert fails.

magreenblatt commented 12 years ago

Original comment by Dmitry Azaraev (Bitbucket: Mystic Artifact).

Comment 1. originally posted by fddima on 2012-05-28T11:09:01.000Z:

In addition to this issue - it will be cool have option to enabling/disabling prerender.

magreenblatt commented 12 years ago

Original comment by Mark Johnston (Bitbucket: Mark Johnston).

Comment 2. originally posted by custa1200 on 2012-05-29T00:29:47.000Z:

I never thought about the fact that Chromium now does pre-rendering which is something we would not want it to do in our line of business app. We would not want any transactions to be run against our core system unnecessarily from a linked page.

magreenblatt commented 12 years ago

Original comment by Dmitry Azaraev (Bitbucket: Mystic Artifact).

Comment 3. originally posted by fddima on 2012-05-29T11:09:28.000Z:

Oh yes, you are right - prerendering is triggered by elements manually.

magreenblatt commented 12 years ago

Original comment by Dmitry Azaraev (Bitbucket: Mystic Artifact).

Comment 4. originally posted by fddima on 2012-05-29T11:15:05.000Z:

UPDATE: To test prerendering is better to use http://prerender-test.appspot.com/ . Currently loading of this url cause crash in cefclient.

magreenblatt commented 12 years ago

Comment 5. originally posted by magreenblatt on 2012-05-29T17:24:49.000Z:

Revision 652 fixes the crash by adding stub implementations for WebKit::WebPrerenderingSupport and WebKit::WebPrerendererClient. Chromium's prerendering implementation currently lives in chrome/renderer/prerender and chrome/browser/prerender. I'm not aware of any plans currently for add prerendering support to the Content API.

magreenblatt commented 12 years ago

Original comment by Dmitry Azaraev (Bitbucket: Mystic Artifact).

Comment 6. originally posted by fddima on 2012-05-29T19:38:13.000Z:

Great, thanks!
PS: I think that stub it is enough. At least at this moment.

magreenblatt commented 12 years ago

Comment 7. originally posted by magreenblatt on 2012-05-30T20:36:12.000Z:

Same problem with CEF1 trunk fixed in revision 657.

magreenblatt commented 12 years ago