magreenblatt
commented
12 years ago Original comment by Anonymous.
Comment 1. originally posted by czarek.tomczak on 2012-09-29T14:27:39.000Z:
I already have a working example.
In v8_impl.cc:
void CefV8MessageHandler(v8::Handle<v8::Message> message, v8::Handle<v8::Value> data)
{
CEF\_REQUIRE\_VALID\_CONTEXT(void(0));
CEF\_REQUIRE\_UI\_THREAD(void(0));
CefRefPtr<CefV8Context> context = CefV8Context::GetCurrentContext();
CefRefPtr<CefBrowser> browser = context->GetBrowser();
CefRefPtr<CefFrame> frame = context->GetFrame();
// TEST ONLY: do alert() on exception
std::ostringstream messageStream;
CefString cefMessage;
GetCefString(message->Get(), cefMessage);
messageStream << "window.alert(\\"CefV8MessageHandler: message: " << cefMessage.c\_str() << "\\")";
frame->ExecuteJavaScript(CefString(messageStream.str()), CefString(""), 0);
CefRefPtr<CefClient> client = browser->GetClient();
if (!client.get())
return;
CefRefPtr<CefV8ContextHandler> handler = client->GetV8ContextHandler();
if (!handler.get())
return;
CefRefPtr<CefV8Exception> exception = new CefV8ExceptionImpl(message);
handler->OnScriptException(browser, frame, context, exception);
} In cef_v8_context_handler.h:
///
// Global V8 exception handler. To get stack trace of the exception call
// CefV8StackTrace::GetCurrent().
///
/\*--cef()--\*/
virtual void OnScriptException(CefRefPtr<CefBrowser> browser,
CefRefPtr<CefFrame> frame,
CefRefPtr<CefV8Context> context,
CefRefPtr<CefV8Exception> exception) {} In cef_context.cc > CefContext::Initialize():
v8::V8::AddMessageListener(&CefV8MessageHandler); I run test.html:
<script>
asd();
</script> And I got an alert:
---------------------------
---------------------------
CefV8MessageHandler: message: Uncaught ReferenceError: asd is not defined
---------------------------
OK
--------------------------- I wondered whether it is necessary to call v8::V8::RemoveMessageListener(&CefV8MessageHandler) in CefContext::UIT_FinishShutdown, but I'm not sure, I don't think we need to do call it. What are your thoughts?
Let me know Marshall if this code looks fine and I'll create a patch. I will also create a unittest in v8_unittest.cc.
Original report by Anonymous.
Original issue 736 created by czarek.tomczak on 2012-09-29T14:17:43.000Z:
Currently there is no way to handle javascript errors along with their stack trace programmatically, you can only do this through developer tools. You can use window.onerror to handle errors, but it runs in a different context and you can't get stack trace of the error in that context. Without stack trace the error message is mostly useless in a complex application, so practically there is no way to handle exceptions programmaticaly in CEF.
There was a CEF thread regarding this issue:
http://magpcss.org/ceforum/viewtopic.php?f=6&t=3408
You can have a global exception handler in v8 engine by calling v8::V8::AddMessageHandler().