search

chromiumembedded / java-cef

Java Chromium Embedded Framework (JCEF). A simple framework for embedding Chromium-based browsers in other applications using the Java programming language.
https://bitbucket.org/chromiumembedded/java-cef
Other
605 stars 135 forks source link

Update CMakeLists.txt #458

Closed FriwiDev closed 7 months ago

FriwiDev commented 7 months ago

There is currently no standard distribution available for build 159 on macos. Fixes the build on macos by updating to build 199.

FriwiDev commented 7 months ago

It appears that this does not fully fix the build on MacOS though, as the clang format fails downloading

FriwiDev commented 7 months ago 
Failed to fetch file gs://chromium-clang-format/a1b33be85faf2578f3101d7806e443e1c0949498 for tools/buildtools/mac/clang-format. [Err: Traceback (most recent call last):
0> Downloading tools/buildtools/mac/clang-format@a1b33be85faf2578f3101d7806e443e1c0949498...
  File "/Users/runner/work/jcefbuild/jcefbuild/jcef/tools/buildtools/external_bin/gsutil/gsutil_4.68/gsutil/gsutil", line 21, in <module>
0> Failed to fetch file gs://chromium-clang-format/a1b33be85faf2578f3101d7806e443e1c0949498 for tools/buildtools/mac/clang-format, skipping. [Err: Traceback (most recent call last):
    gsutil.RunMain()
  File "/Users/runner/work/jcefbuild/jcefbuild/jcef/tools/buildtools/external_bin/gsutil/gsutil_4.68/gsutil/gsutil", line 21, in <module>
  File "/Users/runner/work/jcefbuild/jcefbuild/jcef/tools/buildtools/external_bin/gsutil/gsutil_4.68/gsutil/gsutil.py", line 121, in RunMain
    gsutil.RunMain()
    import gslib.__main__
  File "/Users/runner/work/jcefbuild/jcefbuild/jcef/tools/buildtools/external_bin/gsutil/gsutil_4.68/gsutil/gsutil.py", line 121, in RunMain
  File "/Users/runner/work/jcefbuild/jcefbuild/jcef/tools/buildtools/external_bin/gsutil/gsutil_4.68/gsutil/gslib/__main__.py", line 36, in <module>
    import gslib.__main__
    from six.moves import configparser
  File "/Users/runner/work/jcefbuild/jcefbuild/jcef/tools/buildtools/external_bin/gsutil/gsutil_4.68/gsutil/gslib/__main__.py", line 36, in <module>
ModuleNotFoundError: No module named 'six.moves'
    from six.moves import configparser
]
ModuleNotFoundError: No module named 'six.moves'
]
Downloading 1 files took 2.514757 second(s)
FriwiDev commented 7 months ago

Fixed by reinstalling "six" on the github runners - please ignore my remarks :)

magreenblatt commented 7 months ago

Please submit PRs to https://bitbucket.org/chromiumembedded/java-cef/pull-requests/