search

chromiumembedded / java-cef

Java Chromium Embedded Framework (JCEF). A simple framework for embedding Chromium-based browsers in other applications using the Java programming language.
https://bitbucket.org/chromiumembedded/java-cef
Other
655 stars 147 forks source link

Character encoding in CefResourceHandler #461

Open aalku opened 10 months ago

aalku commented 10 months ago

Is your feature request related to a problem? Please describe. I'm making a CefResourceHandler to display internal resources instead of actual http(s) resources and I can't set the character encoding in the response.

Describe the solution you'd like I want to set the charset of CefResponse. I see it's in the C++ class. https://github.com/chromiumembedded/cef/blob/0d50d5a8c606ab5481c2969f1236d266bd416f31/include/cef_response.h#L124C24-L124C24

Describe alternatives you've considered In the case of html I'm adding an equivalent tag but I think that's not possible in json or js, etc. The tag is <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> As an alternative I could generate the response in the charset encoding that the chromium is using but I don't know if thats defined or system dependant.

Additional context I want to use URL like internal:index.html and that the content is internally provided. All I'm missing is the encoding right now.

Thanks!

aalku commented 10 months ago

I made this changes. I'm not sure if they are fine or they are enough. https://github.com/chromiumembedded/java-cef/compare/master...aalku:java-cef:master

I'll try to make a build and test them but I don't know if I will be able to.

aalku commented 10 months ago

Hi. I found it really hard to build jcefmaven with this changes but I finally got it and tested it and it works. 🥳