search

chronic-care / mcc-project

MCC eCare Plan project planning and documentation
Apache License 2.0
0 stars 1 forks source link

Convert App.tsx to a hook based function component #289

Open savanahmueller opened 1 year ago

savanahmueller commented 1 year ago

easier to profile for performance, analyze, and integrate (and to have less bugs in the application overall from then on).

See #431

savanahmueller commented 10 months ago

Using React best practices. Ask Dan on status. Will not block pilot.

drbgfc commented 10 months ago

This hasn't been done/started. There has always been something of higher priority. It is important, though.

kbertodatti commented 9 months ago

@sravandigitalhie to look into what this will take and how long (potentially) it will take.

drbgfc commented 9 months ago

We need to be very careful with this conversation in regards to testing multiple logins and local storage. Need to focus on getting componentDidMount and update conversations correct. Also, home.tsx is rather large and class based too and an intermediate. That has far less repressions with logic and local storage. We may want to start there.

kbertodatti commented 4 months ago

This would improve code design but doesn't affect app functionality. Iceboxing.

drbgfc commented 4 months ago

This is relevant to 339, though, as it leads to more code for less output, having to understand two versions of design, and, the longer we support it vs update it, the longer it takes to update in the future. If we had updated when the ticket was made it would have taken 1/4 the time it will take now, and so on. The difficult thing about updating App.tsx is the massive amount of testing it will take because it affects everything. But, that's another example, we need more modularization for less side effects. I suppose we should modularize apl.tsx as much as possible before updating to a function component. It will help a little bit. Specifically, we need to break just about everything out of mount/eliminate duplication (also requiresextensive testing, but then less testing and less issues in the future and faster development). Basically, we can be fast now and slow later (what we are doing now), or mostly moderate now and a bit faster later.

On Wed, Mar 6, 2024, 10:52 AM Karen Bertodatti @.***> wrote:

This would improve code design but doesn't affect app functionality. Iceboxing.

— Reply to this email directly, view it on GitHub https://github.com/chronic-care/mcc-project/issues/289#issuecomment-1981188369, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ5UJWAY4LDCZW7PLH3YOLYW43S5AVCNFSM6AAAAAAYQM2M4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGE4DQMZWHE . You are receiving this because you commented.Message ID: @.***>