search

chronicleprotocol / aggor

Oracle aggregator distributing trust among different oracle providers
Other
4 stars 0 forks source link

Use chronicle-std/IChronicle interface #2

Closed pmerkleplant closed 1 year ago

pmerkleplant commented 1 year ago

Generally, we do not want to copy as much code as MakerDAO does but rather use forge install capabilities. However, only specifying the git repo is dangerous wrt to deterministic builds.

This PR fixes the chronicle-std dependency to its freshly released v1 ^^ We also refactor to use the IChronicle interface from chronicle-std instead of the local version.

For more info about how to define versions for forge projects, see how forge-std does it.

pmerkleplant commented 1 year ago

Also adding @deep-quality-dev as a reviewer to let him know about the "having fixed version for dependencies" guideline.

EDIT: Can only add one reviewer -.-

pmerkleplant commented 1 year ago

Closing in favor of #4.