search

chronicleprotocol / aggor

Oracle aggregator distributing trust among different oracle providers
Other
4 stars 0 forks source link

[DRAFT] Possible fixes for overflow and scaling issues #8

Closed pmerkleplant closed 1 year ago

pmerkleplant commented 1 year ago

There are two potential issues in Aggor:

  1. The LibUniswapOracles::readOracle function may have overflow and revert
  2. The Aggor::_tryReadUniswap function may return zero value, which it is not allowed to do.

This PR offers possible fixes for the issues. However, both can be solved differently too.

Created this PR as DRAFT to start a discussion.

pmerkleplant commented 1 year ago

Ping @deep-quality-dev