pmerkleplant commented 9 months ago

Refactors Scribe to use the first byte of a feed's address as their identifier instead of a "random" storage index. This allows backend systems to not have to know an instance's internal state in order to create the IScribe.SchnorrData payload.

Breaking Changes:

IScribe.SchnorrData.signersBlob got renamed to IScribe.SchnorrData.feedIds
IScribe's SignerNotFeed(address signer) renamed to error InvalidFeedId(uint8 feedId)
IScribe's SignersNotOrdered() renamed to error DoubleSigningAttempted(uint8 feedId);
- Note that double signing is now prevented via bloom filter usage instead of expecting strict ordering
The FeedLifted and FeedDropped events updated to emit the feed's id instead of their index
Removed function maxFeeds()(uint8). The maximum number of supported feeds is type(uint8).max + 1
feeds read and management functions updated to take/return feed ids instead of indexes
lift and drop function updated to take/return feed ids instead of indexes
IScribeOptimistic::opFeedIndex() updated to opFeedId()

This PR shall only be merged once the changes are audited!

pmerkleplant commented 9 months ago

Force pushed to rebase to v1.2.0.

pmerkleplant commented 8 months ago

Force push to rebase to current main. Diff to main only touched offchain code, namely chaincheck and docker/

openzeppelin-code[bot] commented 8 months ago

all: v2 refactoring to use feed byte identifier

Generated at commit: 876c2498e33cb5d0234e8f652e33e4b2254dedd7

🚨 Vulnerabilities Summary

Process Issues Results

Contract Inspector high
note
low
critical
Total 1
25
6
1
33

Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

chronicleprotocol / scribe

all: v2 refactoring to use feed byte identifier #23

all: v2 refactoring to use feed byte identifier

🚨 Vulnerabilities Summary

Process	Issues	Results
Contract Inspector	high note low critical Total	1 25 6 1 33
Dependency Checker	Total	0