Closed GoogleCodeExporter closed 8 years ago
Thanks for the patch! Can you confirm the problem occurs with the latest
snapshot?
Original comment by johnpeb@gmail.com
on 28 Nov 2010 at 8:46
Hi,
actually my last change should do the same:
see
http://code.google.com/a/eclipselabs.org/p/mercurialeclipse/source/detail?r=4207
cf813c44cfce867bb5a75b8017af1cf05694
What is the reason for the patch now?
Does the disconect() not work for you?
Regards,
Andrei
Original comment by iloveeclipse
on 28 Nov 2010 at 8:50
Made my patch against b4b3c05238.
Expression of the main conditional block in HgMoveDeleteHook#deleteProject(...)
made my to think that it was dealing with physical files removal, so I skipped
in-depth analysis if it.
While debugging the issue I always removed projects with "Delete project
contents?" unchecked. As a result, disconnect() was skipped and I'm sure you
will understand the rest.
IMO, disconnect() should be called even if project is not removed from the disk.
Original comment by allat...@gmail.com
on 28 Nov 2010 at 9:31
Ok, I've pushed a slightly modified version - can you try it out?
I would not like to disconnect early, as we may still need some data (like
hgroot<->project cache) during this call. So I've put disconnect near to the
end in all three cases.
CU
Andrei
Original comment by iloveeclipse
on 28 Nov 2010 at 10:10
729333e989 resolves the issue.
Thanks!
Original comment by allat...@gmail.com
on 28 Nov 2010 at 10:51
Thank you for report & review.
Closing as fixed.
CU
Andrei
Original comment by iloveeclipse
on 28 Nov 2010 at 10:54
Original comment by johnpeb@gmail.com
on 6 Dec 2010 at 12:20
Original issue reported on code.google.com by
allat...@gmail.com
on 28 Nov 2010 at 4:02Attachments: