search

chrono028 / mercurialeclipse

Automatically exported from code.google.com/p/mercurialeclipse
Other
0 stars 0 forks source link

MercurialEclipse refactoring completely broken #44

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Create a bunch of nested packages with classes inside them
2. Refactor a top level package

What is the expected output? What do you see instead?
Proper refactoring.
I instead see "pathLength" errors and other weird errors.
Like this one: http://gyazo.com/637ed52cbaa0c19405fc3bd69791a1d8
Clicking "Details" shows nothing new.

What version of the product are you using? On what operating system?
Latest version on Windows 7 64-bit, using Eclipse 64-bit.

Original issue reported on code.google.com by ra4k...@gmail.com on 4 Aug 2012 at 2:39

GoogleCodeExporter commented 8 years ago 
This is filed here: 
https://bitbucket.org/aragost/javahg/issue/25/error-renaming-a-directory

Are you running the latest snapshot version of MercurialEclipse? The latest 
version has this potential fix but I don't know if its a complete fix.

Original comment by johnpeb@gmail.com on 4 Aug 2012 at 3:24

GoogleCodeExporter commented 8 years ago 
No difference between the latest marketplace version and the latest snapshot.

Original comment by ra4k...@gmail.com on 4 Aug 2012 at 3:36

GoogleCodeExporter commented 8 years ago 
Just to be clear you're running the latest from this update site? 
http://mercurialeclipse.eclipselabs.org.codespot.com/hg.wiki/update_site/snapsho
ts

I don't know who controls the eclipse marketplace version but it's out of date.

Original comment by johnpeb@gmail.com on 4 Aug 2012 at 3:41

GoogleCodeExporter commented 8 years ago 
What MercurialEclipse should do, is ignore all refactorings until the commit. 
It shouldn't be renaming files itself, but leave Eclipse to do that.

Original comment by ra4k...@gmail.com on 4 Aug 2012 at 3:43

GoogleCodeExporter commented 8 years ago 
And yes, I just updated it and refactored only to get that same "pathLength" 
error.

Original comment by ra4k...@gmail.com on 4 Aug 2012 at 3:44

GoogleCodeExporter commented 8 years ago 
Fixed in latest snapshot.

> What MercurialEclipse should do, is ignore all refactorings until the commit. 
It 
> shouldn't be renaming files itself, but leave Eclipse to do that.

I disagree - renames should be tracked. It is possible to record a rename after 
the fact but I don't see the benefit over the current approach which has worked 
for several years minus this current regression.

Original comment by johnpeb@gmail.com on 4 Aug 2012 at 6:53

GoogleCodeExporter commented 8 years ago 
Ok :)
Also, I've always had refactoring issues with MercurialEclipse. Only this time 
I just recently discovered this Google Code repo :)

Original comment by ra4k...@gmail.com on 4 Aug 2012 at 7:00

GoogleCodeExporter commented 8 years ago 
I updated to the latest snapshot and can confirm that it's fixed. Thank you 
very much!

Original comment by ra4k...@gmail.com on 4 Aug 2012 at 7:19

GoogleCodeExporter commented 8 years ago 
Aha, new bug when deleting: http://gyazo.com/7c16e678881634a19d072c47aa818141

Original comment by ra4k...@gmail.com on 4 Aug 2012 at 6:54

GoogleCodeExporter commented 8 years ago 
Thanks for the report. Can you create a new bug for that and can you include 
the relevant error / stack trace from the error log. To see the error log: 
Window -> Show View -> Other... -> Error Log.

Original comment by johnpeb@gmail.com on 4 Aug 2012 at 7:13

GoogleCodeExporter commented 8 years ago 
Done: 
http://code.google.com/a/eclipselabs.org/p/mercurialeclipse/issues/detail?id=45

Original comment by ra4k...@gmail.com on 5 Aug 2012 at 4:28