search

chronogolf / nativescript-store-update

Apache License 2.0
19 stars 13 forks source link

Allow dialog message overrides #16

Closed sitefinitysteve closed 7 years ago

sitefinitysteve commented 7 years ago

Created new alertOptions property to allow the user to override the LocaleHelper json content... falls back to the LocaleHelper verbage if nothing is set, not sure if you want to make THAT also toggleable or not... but this seems to work.

Also I wasn't sure how you want to test it so I just left it commented out in demo/app.ts

sitefinitysteve commented 7 years ago

I didn't go with this because it always resolved to true

this._alertOptions[key] !== '' || this._alertOptions[key]
SBats commented 7 years ago

Wow, I just saw our tests aren't even up to date... I need to pass on this. Forget about tests for now I guess. I'll handle it while correcting those existing... 🔔 Shame 🔔

SBats commented 7 years ago

I merge the PR but I need to fix and add tests before releasing a new version on NPM. Will do this really soon. Congratulation @sitefinitysteve and thanks for the contribution! 🎉