Regexps are not found on the play store page

chronogolf / nativescript-store-update

Apache License 2.0

19 stars 13 forks source link

Regexps are not found on the play store page #25

Open Burgov opened 6 years ago

Burgov commented 6 years ago

The plugin wouldn't work, so I decided to debug it. This is the app it's about: https://play.google.com/store/apps/details?id=io.neocles.puma.ns

This plugin is trying to match a few regexps, like "itemprop="datePublished">\s*([\w\s,.]*)\s*<\/div>\s*<\/div>", but the string datePublished does not exist in the HTML of above page.

What am I doing wrong?

SBats commented 6 years ago

Sory for the late answer, I don't have much time to work on this plugin at the moment. It might be linked to this issue: https://github.com/chronogolf/nativescript-store-update/issues/20 Or maybe the Google Play store as changed its markup. Unfortunately, they don't provide an easy way to read this, we have to find it in the page markup :(

abhayastudios commented 6 years ago

Running into the same issue. GooglePlayHelper._parseResource returns:

{"date":null,"os":null,"version":null}

It probably has a bit of overhead, but maybe it wouldn't be such a bad idea to use a project that maintains scraping the play store like: https://github.com/facundoolano/google-play-scraper

@SBats what do you think? If you are ok with that I wouldn't mind having a go at it...

SBats commented 6 years ago

Hey! Sure that's a good idea. If someone does it better and open source, we should use their tools. If you feel like doing a PR with that, that would be amazing!

abhayastudios commented 6 years ago

@SBats it turns out to be a bit more complex than I thought since I didn't realize that the plugin I mentioned depends on specific nodejs modules. I tried using nativescript-nodeify but so far no luck. I'll have another go at soon...

yeisnier commented 5 years ago

In case that somebody needed for Google Play.

Regex need to be updated to match the actual markup to:

constants/google-play.ts[6] OS: /Requires\sAndroid<(.|\n)?>(\d{1,3}(.\d{1,3}(.\d{1,3})?)?)/gm, DATE: /Updated<(.|\n)?>(\w\s\d{1,2},\s\d{4})/gm, VERSION: /Current\sVersion<(.|\n)?>(\d{1,3}(.\d{1,3}(.\d{1,3})?)?)/gm,

Matching expression will be on index 2

helpers/google-play.helper.ts[22] infos[key.toLowerCase()] = regEx ? regEx[2] : null

abhayastudios commented 4 years ago

@yeisnier @SBats looks like the whole regex approach is not relevant anymore for scraping the Play store, since they don't publish version numbers anymore. Looks like the way to go is as described in #30. I think this issue should be closed.