Fix issue related to Boolean type usage in a request body

chronogolf / sisense

MIT License

3 stars 6 forks source link

Fix issue related to Boolean type usage in a request body #7

Closed olivierbuffon closed 4 years ago

olivierbuffon commented 4 years ago

I open this PR in order to fix an unexpected behaviour of the parameterize method. I've been able to replicate the bug locally and returning the given object as the fallback result of parameterize_object method fixed the issue. Also I removed the String check condition since it doesn't have any incidence on the process with that new method fallback.

Screen Shot 2020-01-31 at 5 55 09 PM

Thanks @kcarmonamurphy for raising that point, good catch 👍

Fixes #6

olivierbuffon commented 4 years ago

You’re welcome @olimart 😉

olimart commented 4 years ago

Merci bien @olivierbuffon