chronogolf / sisense

MIT License
3 stars 6 forks source link

Get rid of parameterize #8

Closed kcarmonamurphy closed 4 years ago

kcarmonamurphy commented 4 years ago

Boolean values were previously getting converted to null on the output of the parameterize() method. I opened issue https://github.com/chronogolf/sisense/pull/7 and a fix was proposed. However I'm still unsure why we need parameterize(). Why not just do params.to_json?