chronos-tachyon / googletest-bazel

Fork of googletest that uses bazel.build
https://github.com/google/googletest
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

Patch for /trunk/samples/sample5_unittest.cc #386

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
EXPECT_FALSE(!IsPrime(4));   //4 is not a prime number

EXPECT_FALSE(!IsPrime(6));   //6 is also not a prime number

Original issue reported on code.google.com by nageshsh...@gmail.com on 13 Oct 2011 at 8:16

Attachments:

GoogleCodeExporter commented 9 years ago
The current logic is correct, even if a bit confusing. Those statements deserve 
to be rewritten as EXPECT_FALSE(condition).

Original comment by vladlosev on 13 Oct 2011 at 10:22

GoogleCodeExporter commented 9 years ago

Original comment by vladlosev on 13 Oct 2011 at 10:22

GoogleCodeExporter commented 9 years ago
Corrected this in SVN, revision 602.

Original comment by vladlosev on 14 Oct 2011 at 1:20