chronosacaria / MCDungeonsArmors

Bringing the armours of Minecraft Dungeons to Minecraft
Other
22 stars 9 forks source link

Chilling Enchantment #20

Closed AllenWorker closed 2 years ago

AllenWorker commented 3 years ago

Server use PvP toggle https://github.com/manyrandomthings/pvp-toggle

when two player have pvp on, the Chilling Enchantment works fine but when one or both player has pvp off (should not damage each other), there is no damage but the Chilling still affect to the player and the effect never disappear (the counter stay at 0:00 and last forever) unless reconnect.

also want to ask about Heal Allies Enchantment it doesn't seem to work, does it heal Allies when the wearer getting hit? does it also heal the wearer? for now no matter pvp is on or off, it doesn't heal player, haven't test on the pet and other things yet.

chronosacaria commented 3 years ago

Hey, @AllenWorker! I'll definitely look into this. Do you know if the actual effect is active or if it is just showing the effect card?

As far as the Heal Allies Enchantment, you need to make sure that you are on the same /team. So you'll need to use the /team command and set one up. As long as that is the case it will work. The way that it works, though, is whenever the person with the enchantment takes damage, as long as there is someone or something that is on the team within range, it will be healed based on the damage that was taken by the damaged party member.

AllenWorker commented 3 years ago

Chilling Enchantment actual effect is active player is moving really slowly and can not mine anything, the effect last forever unless log off

chronosacaria commented 3 years ago

Thanks for clarifying that!

chronosacaria commented 3 years ago

Okay, @AllenWorker. After messing about with this for a while, I think the solution will have to come from the other dev. There doesn't really seem to be a way for my mod to know what is going on so it might be easier for the other dev to clear negative status effects as well as negate damage via the mixin that they are using. I am sorry that there really isn't more that I can do. I'll wait for a response before closing the issue

AllenWorker commented 3 years ago

Are you able to reproduce the issue? so you are saying it's PvP toggle causing it? If that's the case I can try to find an alternative mod to achieve that. Thanks for the investigation.

chronosacaria commented 3 years ago

I'm sorry, my messages are a bit erratic because I'm on holiday. I could absolutely see how the issue could be reproduced. I could not find a way around it